Markus Kahl

Results 16 comments of Markus Kahl

So would it be fixed by using a more specific selector when you have two select2s? I.e. ``` select2 'value', css: '#selectid' ``` I mean just picking the first one...

I need this badly. I don't think it's possible right now with swarmkit which will likely force me to use kubernetes (which does support preemption) instead.

I'm getting `undefined method 'audited'` on `ruby 2.5.1p57 (2018-03-29 revision 63029) [x86_64-linux]` with `rails (5.1.6)` and `audited (4.8.0)`. Also followed the instructions in the readme. My model looks like that:...

I just added ``` require 'audited' ``` to the top of the file in the model.

> @machisuji Would you be able to revise this PR? Oh boy, sorry! I completely forgot about that. I will do that first thing tomorrow morning! Thanks for your patience.

@lgarron I've pushed some changes which should address your remarks.

Just pushed a tiny correction to use [double quotes](https://github.com/github/secure_headers/pull/490/files#diff-6f8c2fbede52ee1e1081d604950f5b34dd81518a53a477b64d9a1fdf00ebe5fbR217) where single quotes were used before.

@lgarron Thanks for the update. I think it's the right call. If people want to save precious bytes, they can make sure not to pass in duplicate sources themselves, really....

It looks good over all (also the multitenancy PR) but I'm still looking into why I'm getting duplicate key errors on upserting the job status. On a positive side note,...

> > > * [ ] Trying to instantiate a project copy, I got this error on first try: > > > > > > ``` > > > E,...