IXWebSocket icon indicating copy to clipboard operation
IXWebSocket copied to clipboard

Get rid of double indirection

Open marton78 opened this issue 1 year ago • 2 comments

Hi, first of all thanks for this great library.

One hint: you could get rid of the double indirection in

using OnMessageCallback = std::function<void(const WebSocketMessagePtr&)>;

by changing it to

using OnMessageCallback = std::function<void(const WebSocketMessage&)>;

This could also be done in a backwards-compatible fashion by offering a second overload, e.g.:

using OnMessageCallbackNew = std::function<void(const WebSocketMessage&)>;
void setOnMessageCallback(const OnMessageCallbackNew& callback);

marton78 avatar Dec 19 '24 15:12 marton78