Remove magic number

[jspc]

Currently this tool throws exit(2) on error. This doesn't mean anything and is a magic number.

Instead this PR defines it as an error.

The choice of 2 is out of the scope of this PR.

[matryer]

@jspc fair enough. I like to avoid using CAPS as constant names, and maybe it should exit with 1 instead? There is nothing special, just need a non-zero exit code.

[jspc]

Happy to change it, I wrote it with a cap and underscore because that's the convention we see in unix usually.

Though, of course, that's usually c or bash.

Commit incoming.

On Wed, 9 May 2018, 19:51 Mat Ryer, [email protected] wrote:

@jspc https://github.com/jspc fair enough. I like to avoid using CAPS as constant names, and maybe it should exit with 1 instead? There is nothing special, just need a non-zero exit code.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/machinebox/appify/pull/3#issuecomment-387839306, or mute the thread https://github.com/notifications/unsubscribe-auth/AAxclb2HLMxsb3znxYpGlrNaxVtWkjtmks5twzqngaJpZM4T2mwM .