mlx icon indicating copy to clipboard operation
mlx copied to clipboard

UI needs to implement a logout page/button/route

Open Tomcli opened this issue 3 years ago • 5 comments

Is your feature request related to a problem? Please describe. Right now there's no way for the admin to logout other than clear up the browser cookies, so we need a logout page to simply this process.

Describe the solution you'd like A clear and concise description of what you want to happen.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Add any other context or screenshots about the feature request here.

Tomcli avatar Jun 04 '21 19:06 Tomcli

I don't think we need a new page. Just a logout button should suffice.

An even quicker fix could be to just implement a "Route" instead of a whole page. Meaning, if a logged-in admin user appends "/logout" to the MLX UI's base URL in the browser's address bar, i.e. https://ml-exchange.org/logout (similar to the login URL: https://ml-exchange.org/login)

ckadner avatar Oct 14 '21 19:10 ckadner

@Zachary-Fernandes -- See #41 for information about how the /login was implemented

ckadner avatar Oct 14 '21 19:10 ckadner

@yhwang -- could you provide some guidance, as to how a logout function should be implemented? ... removing session cookies, userInfo, etc. Thanks!

ckadner avatar Oct 14 '21 20:10 ckadner

@ckadner yes, a route to handle /logout should be enough. but we also need to handle the /logout on the server side to remove the session.

yhwang avatar Oct 15 '21 04:10 yhwang

I can also work on this issue as well if zack hasn’t started on it, or needs some help

Prasantacharya avatar Oct 19 '21 16:10 Prasantacharya