mlx
mlx copied to clipboard
Model deployment code template cannot change namespace
Describe the bug
Right now the model deployment code template is hard coded to the anonymous namespace, we need to make it configurable in order to work in the multi-user environment.
To Reproduce
Steps to reproduce the behavior:
- Go to '...'
- Click on '....'
- Scroll down to '....'
- See error
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Environment
- OS: [e.g. iOS]
- Browser [e.g. chrome, safari]
- MLX Version [e.g. 22]
Additional context
Add any other context about the problem here.
I will hard-code a quick fix (1c451fa) to use namespace "mlx" until I get a chance to add a new variable to the API
@Tomcli -- QQ do we still need to use your custom kfserving component.yaml here?
https://github.com/machine-learning-exchange/mlx/blob/ef06fa28ffba1cdf22d6dfa4f81fb426f2fc7f0c/api/server/swagger_server/code_templates/serve_kfserving.TEMPLATE.py#L39
It differs only slightly from this one: https://raw.githubusercontent.com/kubeflow/pipelines/master/components/kubeflow/kfserving/component.yaml
@ckadner you can use the official one at https://raw.githubusercontent.com/kubeflow/pipelines/master/components/kubeflow/kfserving/component.yaml
just that some parameter mapping needs to be changed.