gpr-docker-publish
gpr-docker-publish copied to clipboard
Use Git Tags as additional Docker Image Tags
I added the functionality to implicitly use Git Tags as additional Docker Tags. Means: If you commit a new Git Tag, an appropriate additional Docker Tag with the same name is going to be created as well. I fixed a few typos and introduced a Github Workflow to get this action tested.
I already did an integration test by using this functionality here: https://github.com/saubermacherag/docker-ansible-alpine
The big advantage I see is that you can comfortably draft a realease on Github which implicitly creates a GIT tag which will also become the docker tag.
Due to issue https://github.community/t5/GitHub-Actions/docker-pull-from-public-GitHub-Package-Registry-fail-with-quot/m-p/32782 which basically says, that Github Actions cannot rely on Docker Images on Github's Package Registry without authentication
I also added the DOCKERHUB_REPOSITORY option which allow to push the image to dockerhub instead of GPR.
btw. this was originally a fork of a fork and I somehow wasn't able to sync this PR with your repo. And I'm not able to resolve the conflicts here on Github.
resolved conflicts. Tests for dockerhub integratoin pending...
Dockerhub Pushes work now.
I'm not sure about expanding the scope of this action to include pushing to other registries? There are other Actions for that. The purpose of this Action was to make it easy to push to GPR since there are some nuances for that you don't need to worry about this Action.
What do you think?
Thanks for your review :-D
My point of including Dockerhub is this issue here: https://github.community/t5/GitHub-Actions/docker-pull-from-public-GitHub-Package-Registry-fail-with-quot/td-p/32782
The tl;dr version is: At the moment it is not possible to pull from public github package registries without providing credentials, which makes this whole Package Registry thing almost unusable. Therefore I added the Dockerhub Repo option.
But I do understand your point and if this option is a nogo and we just shall wait for the fix from github side, please just close this PR ;-)
I'd like to see this PR go in, too!