TopicNet
TopicNet copied to clipboard
Dataset's dictionary not updated if one changes the collection dynamically
- Create a
dataset - Call
dataset.get_dictionary() - Change dataset's
_databy renaming one of modalities (eg. lemmatized -> new_lemmatized) - Try to build a topic model using the
dataset
Result: old modality in model's Phi
Expected: new modality in Phi
P.S.
One should also check that dataset._modalities is up-to-date
See? Exactly - if you change the _ variables or methods we don't guarantee proper functionality. You should know what you are doing when using those
Well... yees... Ok. Then it should be clearly stated in the docstring that currently Dataset provides no way to modify the contents of a text collection (changing document/renaming document/adding modality/...). If you want to change something — use text editors, pandas, csv or something else.