docker-machine-driver-xhyve icon indicating copy to clipboard operation
docker-machine-driver-xhyve copied to clipboard

Published 20 hours ago • verified publisher icon machine-drivers

Switch from using hdiutil to parsing the iso file directly.

Open dlorenc opened this issue 7 years ago • 7 comments

I'm still not completely happy with this code, but I wanted to send it out early and see what you thought @zchee.

dlorenc avatar Jun 29 '17 01:06 dlorenc

@dlorenc Thanks. I know iso9660 package (but was not digging), it's make sense. Some users waiting to release the new version and pre-build binary. I'll check that package and test this pull request after the release new version. https://github.com/zchee/docker-machine-driver-xhyve/pull/182

zchee avatar Jun 29 '17 01:06 zchee

@dlorenc

I'm still not completely happy with this code

OK, I'll wait for the complete code. Could you rebase to master(for now)? Maybe CI test is successful.

zchee avatar Jun 29 '17 02:06 zchee

and, /cc @praveenkumar because he wrote the related code.

zchee avatar Jun 29 '17 02:06 zchee

Thanks for notification, I will go through it and test.

praveenkumar avatar Jun 29 '17 05:06 praveenkumar

Tested this PR with CentOS/b2d iso and it able to extract kernel options as expected. 👍

praveenkumar avatar Jun 29 '17 06:06 praveenkumar

@dlorenc This PR and #189, Which is a priority?

zchee avatar Jul 13 '17 17:07 zchee

#189, I'll rebase this one after :)

dlorenc avatar Jul 13 '17 17:07 dlorenc