Mat Kelly

Results 844 comments of Mat Kelly

Thanks again for the report, @ProximaNova. Can you run `ipwb --version` and comment on what version of ipwb you are using? e.g., ```sh % ipwb --version InterPlanetary Wayback 0.2023.07.20.2112 ```...

Hi @ProximaNova, since you were able to overcome the original problem on your system, I am going to close this issue. I have created a separate ticket for your suggestions...

Per the Python 3.12 release notes, `pkg_resources` is not longer installed by default in virtual environments in addition to the absence of `distutils`, `setuptools`, and `easy_install` (see https://github.com/python/cpython/issues/95299). ipwb uses...

The testing GH Action reports, "from six.moves.urllib_parse import urlsplit, urlunsplit" only for Python 3.12. `six` ought to be removed and its usage adapted to Python 3 built-in modules if possible,...

/Users/runner/work/ipwb/ipwb/ipwb/util.py:27: DeprecationWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html - [ ] Identify and implement an alternative to `pkg_resources` for Python 3.12 support.

`parse_version()` within `pkg_resources` is the issue here. An alternative to obtain the package version is `importlib.metadata import version` but that does not split the version based on sortable keys, as...

The main reason for this check was to send a communicate with the IPFS daemon differently if its version was < 0.4.10, which is far from supported by ipwb. Regardless,...

An alternative can be had in the [packaging](https://pypi.org/project/packaging/) external module. ``` from packaging.version import parse, Version parse("1.1.1") < parse("1.2") ```

Another substitute from replay.py is the need for replacing: ```index_file_name = pkg_resources.resource_filename(__name__, index_file_path)``` with the equivalent from [ importlib.resources](https://docs.python.org/3/library/importlib.resources.html#module-importlib.resources)

The repo for the Action has been deprecated, see https://github.com/actions/create-release.