Mat Kelly

Results 844 comments of Mat Kelly

The `await` and Promises are not working as expected. Execution proceeds even if the promise has not resolved.

@N0taN3rd Ideally that would be the way it's done, so we would not be dependent on whether the popup is open (and perhaps just indicate processing in the icon). The...

@N0taN3rd 👍 , also #7 is high on the list, which your edits with the above might assist in being remedied.

Circling back to this, the two calls to `saveAs` are problematic, particularly when the `asynchronouslyFetchImageData()` in warcGenerator.js does not seem to be doing its namesake but instead relying on the...

To be changed in `setSaveChangesButtonEnabledBasedOnOptionsChange()` in `options.js`

This issue remains, @N0taN3rd , despite #93. The Host header is still not present in Request record payloads.

This might be fixed by limiting the capture to the current tab in the response and request capture filters but requires a bit more testing, which should be easy enough...

For testing, throw this page ( http://warcreate.com/tests/bug7.html ) up in a tab, new tab, enable WARCreate with a simple HTML page, and note the noise included in the WARC.

Is this the right functionality or should it be "all of the tabs the user visited with WARCreate enabled."

The state is currently read correctly but the red dot icon is not shown until the warcreate icon is clicked.