analyze-css icon indicating copy to clipboard operation
analyze-css copied to clipboard

Fixing the base64 rule

Open gregoirelinot opened this issue 2 years ago • 2 comments

Fixing the regex as base64 can start with something else than [a-zA-Z-0-9], a false assumption which I took when creating the regex initially. An example of this is the first bytes of a jpeg images: FF D8 FF which is /9j/ in base64

gregoirelinot avatar Jul 07 '22 19:07 gregoirelinot

Thanks for this PR. Would be great if you can add a test case with base -64 encoded jpeg that you've mentioned.

macbre avatar Jul 07 '22 20:07 macbre

Thanks for this PR. Would be great if you can add a test case with base -64 encoded jpeg that you've mentioned.

will do

gregoirelinot avatar Jul 08 '22 08:07 gregoirelinot