jamf-pro-sdk-python icon indicating copy to clipboard operation
jamf-pro-sdk-python copied to clipboard

Published 20 hours ago • verified publisher icon macadmins

Credential Providers Refactoring

Open liquidz00 opened this issue 6 months ago • 0 comments

Overview

This PR implements the following:

  • Refactored BasicAuthCredentialProvider to UserCredentialsProvider throughout codebase
  • Refactored LoadFromAWSSecretsManager, PromptForCredentials and LoadFromKeychain into helper functions instead of classes. Each function returns a CredentialProvider type that is specified or raises a TypeError if an invalid credential provider was passed.
  • Adjusted top-level imports of package accordingly--credential provider classes and helper functions can be imported at the top level
  • Updated project docs with refactors, breaking changes, and added section on helper functions in the getting started page.

Closes #47

Secondary

The integration unit test steps have been commented out in the runner (.github/workflows/main_pr_tests.yaml) for now after discussing with Bryson.

liquidz00 avatar May 09 '25 19:05 liquidz00