Bruno Macabeus

Results 43 comments of Bruno Macabeus

Very thank you for the review. I'll update the package following your suggestions, as well as change to use [`chokidar`](https://github.com/paulmillr/chokidar) (or [`watchman`](https://github.com/facebook/watchman)?) instead of webpack loader, so we'll could use...

@stasm Hey, I just released a new version: https://github.com/macabeus/fluent-typescript/releases/tag/0.0.3 ! 🎉 Now I think that this tool is so much more stable. Could you take a review on codebase again,...

@stasm I was very busy on the last couple of weeks, but finally I added support to `@fluent/react` as well as `react-i18next`, and I added auto-emit when start to watch....

@kevinresol I think that adding types would resolve this problem too: https://github.com/projectfluent/fluent.js/issues/466

@kevinresol Okay, I understand now better what do you want. For example: ```js require = require('esm')(module); const { FluentBundle, FluentResource } = require('./fluent-bundle/esm/index.js') const resource = new FluentResource(` -term-with-typo =...

I think that it would be better not to demand the `main` field when `browser` is present. NPM doc is reasonable when explaining that it's an "instead of". Otherwise, I'm...

Testing using `false`... And raises a warning on VSCode because the expected type is `string`. Probably it'll raise an error on other tools too. ![image](https://user-images.githubusercontent.com/9501115/122656102-ae30fe00-d14f-11eb-85db-1b7b1cf1d076.png) I also tested using an...

Related PR: https://github.com/Ryujinx/Ryujinx/pull/1530

I'm a bit late for the party, but... I don't think we need a git submodule here *either* keeping it on this repository. One of the advantages of the JS...