react-json-view
react-json-view copied to clipboard
Keyboard handler for collapse/expanding
- Braces, String and Function keyboard handler
Fixes #355
This PR is the bare minimum to add keyboard support for collapsing/expanding braces/functions/strings with tab index, keydown handler, and aria roles/attributes
@mac-s-g is there a set of maintainers I should assign for review?
@mac-s-g is there a set of maintainers I should assign for review?
my pr is also waiting for @mac-s-g response. In the meantime, i have created and published a fork :) https://github.com/galr52/react-extreme-json-view
@mac-s-g is there a set of maintainers I should assign for review?
my pr is also waiting for @mac-s-g response. In the meantime, i have created and published a fork :) https://github.com/galr52/react-extreme-json-view
@galr52 - it looks like your 1.22
publish doesn't have my changes built in it, could you please rebuild + publish again?
@mac-s-g is there a set of maintainers I should assign for review?
my pr is also waiting for @mac-s-g response. In the meantime, i have created and published a fork :) https://github.com/galr52/react-extreme-json-view
@galr52 - it looks like your
1.22
publish doesn't have my changes built in it, could you please rebuild + publish again?
i rebuild & published
https://codesandbox.io/s/react-extreme-json-test-mcujc - it doesn't seem to have those changes when using the latest. The elements should have role=button
if my changes are in the build
https://codesandbox.io/s/react-extreme-json-test-mcujc - it doesn't seem to have those changes when using the latest. The elements should have
role=button
if my changes are in the build
sorry, you are right. my mistake. try the latest version