react-json-view icon indicating copy to clipboard operation
react-json-view copied to clipboard

Keyboard handler for collapse/expanding

Open nictownsend opened this issue 3 years ago • 7 comments

  • Braces, String and Function keyboard handler

Fixes #355

nictownsend avatar Apr 29 '21 15:04 nictownsend

This PR is the bare minimum to add keyboard support for collapsing/expanding braces/functions/strings with tab index, keydown handler, and aria roles/attributes

nictownsend avatar Apr 30 '21 08:04 nictownsend

@mac-s-g is there a set of maintainers I should assign for review?

nictownsend avatar May 04 '21 08:05 nictownsend

@mac-s-g is there a set of maintainers I should assign for review?

my pr is also waiting for @mac-s-g response. In the meantime, i have created and published a fork :) https://github.com/galr52/react-extreme-json-view

galr52 avatar Jun 16 '21 13:06 galr52

@mac-s-g is there a set of maintainers I should assign for review?

my pr is also waiting for @mac-s-g response. In the meantime, i have created and published a fork :) https://github.com/galr52/react-extreme-json-view

@galr52 - it looks like your 1.22 publish doesn't have my changes built in it, could you please rebuild + publish again?

nictownsend avatar Nov 30 '21 12:11 nictownsend

@mac-s-g is there a set of maintainers I should assign for review?

my pr is also waiting for @mac-s-g response. In the meantime, i have created and published a fork :) https://github.com/galr52/react-extreme-json-view

@galr52 - it looks like your 1.22 publish doesn't have my changes built in it, could you please rebuild + publish again?

i rebuild & published

galr52 avatar Nov 30 '21 14:11 galr52

https://codesandbox.io/s/react-extreme-json-test-mcujc - it doesn't seem to have those changes when using the latest. The elements should have role=button if my changes are in the build

nictownsend avatar Dec 01 '21 10:12 nictownsend

https://codesandbox.io/s/react-extreme-json-test-mcujc - it doesn't seem to have those changes when using the latest. The elements should have role=button if my changes are in the build

sorry, you are right. my mistake. try the latest version

galr52 avatar Dec 01 '21 12:12 galr52