R.swift icon indicating copy to clipboard operation
R.swift copied to clipboard

Accept optional [preferredLanguages]

Open ReDetection opened this issue 1 year ago • 2 comments

Hi. I've been happily using R.swift for a long time now, so I missed the whole 6.x version and now I am migrating from the version 5 to the version 7. Everything seems to be really smooth (thanks!) except one little thing: previously preferredLanguages parameter did accept nil, so I can pass it down my call chain if I want to, and now I can no longer do that. Funny enough, it seems every part of R.swift still accepts preferredLanguages: nil just fine, except the very top autogenerated file. Here is the PR to fix that.

One note: I could not locate where the tests of those are located, I can only see the example app, which doesn't really test anything, so I am kinda confused here.

ReDetection avatar Nov 15 '24 19:11 ReDetection

@tomlokhorst I would appreciate a review 🙏

ReDetection avatar Dec 02 '24 12:12 ReDetection

Thank you for this PR! I haven't reviewed it yet, we will review it when we have free time available.

tomlokhorst avatar Dec 28 '24 11:12 tomlokhorst