R.swift icon indicating copy to clipboard operation
R.swift copied to clipboard

Introduce useDevelopmentLanguageDefaults option

Open scaio opened this issue 5 years ago • 4 comments

The problem this PR is trying to solve:

https://github.com/mac-cain13/R.swift/issues/563

What this PR does:

This PR introduces a new flag use-development-language-defaults which when passed will cause the NSLocalizedString macros to have the value: option set to the translation value in the developmentLanguage if such a value is available and we are not using base localization.

Testing

  • I could really use some insight on how to properly unit test this behavior.

End notes

First time opening a PR, please let me know if I missed something. I love this project and use it in pretty much all my apps. I think it would be great to have this functionality but please let me know if you think otherwise :)

scaio avatar Oct 02 '19 11:10 scaio

@mac-cain13 Do you planned to include this feature to project?

dphov avatar Oct 24 '19 11:10 dphov

@mac-cain13 would be nice to have this feature.

snowman647 avatar Feb 17 '20 19:02 snowman647

It would be great if this makes into new release! Please take a look 🙏

ghost avatar Mar 06 '20 07:03 ghost

If this makes us work more like Apples own API I would include this, but I think we're in line with NSLocalizedString now. We can discuss this further in https://github.com/mac-cain13/R.swift/issues/563

mac-cain13 avatar Apr 22 '20 14:04 mac-cain13