R.swift icon indicating copy to clipboard operation
R.swift copied to clipboard

Localizable strings comments

Open tomlokhorst opened this issue 9 years ago • 4 comments

Implements https://github.com/mac-cain13/R.swift/issues/232, continuation of https://github.com/mac-cain13/R.swift/pull/235

I've merged the current master branch into @nolanw's code, making it all Swift 3.

Todo:

  • [x] Multiline or multi-part comments should be separated by \n
  • [ ] Comments should be printed in generated code
  • [ ] All tests should succeed
  • [ ] Consider splitting comment parser from localized strings parser [1]
  • [ ] Consider moving strings parser to separate library

[1]: Instead of flat out replacing the existing LocalizedStrings parser, we could split out the comments parser. That way, if there's an error in our own parser, the localized strings will still be generated, just with missing comments.

tomlokhorst avatar Oct 24 '16 15:10 tomlokhorst

Any plan to continue and finish this work? The last update of this MR was 1.5 years ago.

If no one is going to pick it up anytime soon, I would like to give it try.

hujunfeng avatar Apr 07 '18 18:04 hujunfeng

No plans from me, I ran outta steam.

nolanw avatar Apr 07 '18 18:04 nolanw

We sort of stopped with this PR when @mac-cain13 and I realised we didn't want to replace your Strings parser, but only augment it.

So only build a Strings Comment parser, and combine that with the existing Strings parser. That way, existing file won't break if the new parser isn't perfect.

Anyway, that was the idea, but we never did anything more with it.

tomlokhorst avatar Apr 09 '18 22:04 tomlokhorst

@tomlokhorst Are we going to see #232 in production any time soon, please?