qBittorrentDarktheme icon indicating copy to clipboard operation
qBittorrentDarktheme copied to clipboard

Waiting for release 4.3.0

Open maboroshin opened this issue 4 years ago • 2 comments

Waitting to qBittorrent ~ver 4.2.3~ or ~ver 4.2.4~ or ~ver 4.2.5~ or ver 4.3.0 or later

  • (Merged) Log text color: Convert the Log widget to use custom View/Model #12144 in here now
  • Change icons? (Add icon's ID) : Map Icons with IDs #10948, Icon theme support in qbittorrent #10903 (4.3.0)
  • Allow changing RSS article list colors from custom UI theme #13246 (4.3.0)
  • Use palette colors in pieces bars #13256 (4.3.0)
  • Use palette colors in RSS feeds #13226 (4.3.0)

I still don't understand how to reflect. Please tell me. I understand easy programming only.

Also

  • Redesigning theme icons #12169

Memo: Light icons

  • MainMenu.PauseAction
  • MainMenu.PauseAllAction
  • Torrent.Paused
  • Torrent.Error
  • TransferList.PauseAction

Memo:

Next : https://github.com/maboroshin/qBittorrentDarktheme/issues/22 Waiting for release Next

maboroshin avatar Mar 25 '20 15:03 maboroshin

About Peace Bar, My understanding is incomplete, but the code looks like this. "Palette.Base" and "Palette.Highlight" will be reflected in the actual bar.

*Color1: Missing=Unavailable = (Palette.Base in config.json) *Color2: Partial=(m_dlPieceColor)=(Green based in the program code, Get the brightness of Palette.Highlight) *Color3: Completed=Available = (Palette.Highlight in config.json) = (RSS.title? but not used?)

https://github.com/qbittorrent/qBittorrent/pull/13256/files :

https://github.com/qbittorrent/qBittorrent/blob/master/src/gui/properties/downloadedpiecesbar.cpp
rowHTML.arg(backgroundColor().name(), borderColor, tr("Missing pieces"))
rowHTML.arg(m_dlPieceColor.name(), borderColor, tr("Partial pieces"))
rowHTML.arg(pieceColor().name(), borderColor, tr("Completed pieces"))
rowHTML.arg(backgroundColor().name(), borderColor, tr("Unavailable pieces"))
rowHTML.arg(pieceColor().name(), borderColor, tr("Available pieces"))
QColor PiecesBar::backgroundColor() const {
    return palette().color(QPalette::Base);
}
QColor PiecesBar::borderColor() const {
    return palette().color(QPalette::Dark);
}
QColor PiecesBar::pieceColor() const {
    return palette().color(QPalette::Highlight);
}

https://github.com/qbittorrent/qBittorrent/blob/master/src/gui/properties/downloadedpiecesbar.cpp

QColor dlPieceColor(const QColor &pieceColor) {
  const QColor green {Qt::green};
  return QColor::fromHsl(green.hslHue(), pieceColor.hslSaturation(), pieceColor.lightness());
}

m_dlPieceColor {dlPieceColor(pieceColor())}
  • src/gui/transferlistmodel.cpp // QPalette::Base is used for the background of the Treeview (Comment only)
  • https://github.com/qbittorrent/qBittorrent/blob/master/src/gui/rss/rsswidget.cpp QPalette::Highlight article->title()

maboroshin avatar Sep 19 '21 02:09 maboroshin

Waiting for release Next https://github.com/maboroshin/qBittorrentDarktheme/issues/22

maboroshin avatar Sep 19 '21 03:09 maboroshin