qBittorrentDarktheme icon indicating copy to clipboard operation
qBittorrentDarktheme copied to clipboard

Unknown issue

Open maboroshin opened this issue 4 years ago • 8 comments

Unknown issue with dark theme. Probably need to improve the program, not only the theme.

Let me know if you find a solution.

Unsolved color

Corrected on ver 4.5.0

Corrected on ver 4.3.0

Corrected on ver 4.2.2


Sample references

maboroshin avatar Feb 27 '20 10:02 maboroshin

  • [x] Link text color (blue) is not visible** in Option and About. Also RSS reader, Update dialog.

If it is changed to Upload text color, it will visible in both dark and white. Visible in many situations without writing a new QSS (similer CSS).

Its value is : #3299ff (50, 153, 255) from src/gui/properties/speedplotview.cpp link7

HTML RGB (setText, setHtml) src/gui/aboutdialog.cpp link1

aboutdialog.ui ? (QLabel a href) link2

src/gui/thanks.html / src/gui/gpl.html (HTML via aboutdialog.cpp) link3

src/gui/optionsdialog.ui ? (QLabel a href) link4

same link5

src/gui/advancedsettings.cpp used makeLink (Qlabel a href) link6

src/gui/mainwindow.cpp (QString a href) qbqa

src/gui/rss/rsswidget.cpp (QString) RSS reader. (No image)

maboroshin avatar Feb 27 '20 10:02 maboroshin

  • [x] Log text color seems to have the same problem as Transfer list.

But easy to do. It should change blue to #3299ff. On many darks, this initial value #3299ff will remain visible.

Convert the Log widget to use custom View/Model #12144 of Pull requests in official qBittorrent, in progress.

HTML RGB (QString font color=) src/gui/executionlogwidget.cpp log

maboroshin avatar Feb 27 '20 10:02 maboroshin

  • [x] Progress/Availability color is not dark. (White and blue)

This code is: https://github.com/maboroshin/qBittorrentDarktheme/issues/5#issuecomment-922402612

~~But easy to do. It should change white to gray, e.g. #c0c0c0 (Qt::lightGray). The contrast is reduced.~~

~~Internal RGB: Qt::white, QT::blue~~

src/gui/properties/piecesbar.cpp
src/gui/properties/downloadedpiecesbar.cpp / pieceavailabilitybar.cpp Availability

maboroshin avatar Feb 27 '20 10:02 maboroshin

Margin and text color with right-click on the transfer list.

Green: transferlistwidget.cpp - tristateaction.cpp - tristatewidget.cpp I do not know the element name. Changes are possible but partial. The background color is changed, but text color and the margin remains. qbContext2

Images by adem4ik.

image image

Different font than the default.

maboroshin avatar Feb 27 '20 11:02 maboroshin

Crrected: ~~Cannot be separated by CSS (QSS). I am trying. When I narrow down here, others narrow down and become invisible.~~

  • [x] Orage: (On ver 4.2.2, Orange issue only corrected) Selector is the same as right-clicking on a column.
  • QTabWidget QStackedWidget QTreeView QMenu::item

And There are can't used.

  • QTabWidget QStackedWidget QHeaderView QMenu::item
  • QTabWidget QStackedWidget QHeaderView QTreeView QMenu::item
  • QTabWidget QStackedWidget QTreeView QHeaderView QMenu::item

Thus, they cannot be distinguished.

qtList2

Same problem as orange. Tool button context menu. Making this check visible will make other margins wider.

  • [x] Yellow : (On ver 4.2.2, Yellow issue corrected) Common selector:
  • QMenu::item

There are can't used.

  • QToolBar QMenu::item

qbtool

maboroshin avatar Feb 27 '20 11:02 maboroshin

I'm also having color issues but nothing like you have described already. Some text is still dark and the background of some fields are still white. This could be an issue with Gnome but I am unable to find anything about this yet. I'm still a beginner when it comes to programming but I might be able to help with testing. Screenshot from 2020-04-02 00-27-14

charmesal avatar Apr 01 '20 22:04 charmesal

  • Icons: Error, Warning

Can't change.

image

maboroshin avatar Jan 03 '21 20:01 maboroshin