Malte

Results 59 comments of Malte

Sure, I am. I already looked at the current implementation and noticed that Geohash maintains its state internally as geohash string. How would you refactor the class in a sane...

For a personal project I converted the algorithm used by https://github.com/sunng87/node-geohash to PHP. Since there is also #3 (Geohash36) maybe it would be the better way to have a GeoHashInterface...

Okay, fine. :+1: I will prepare a PR on the weekend to be discussed further then.

@xabbuh Thanks for your feedback. I wasn't even sure if this is the right way to do it? I will check the required types thing you mentioned

@thoroc I forgot it to be honest. I will look into it tonight. Thanks for the reminder

Maybe we should finally write the tests?

I am facing the same issue. I am using v next7 und angular 7.2

@raisen Totally true. Is this lib even maintained? Anyone?

@bjguillot Nice to hear! Maybe I could provide some stuff as PR. This would be for a Release 3.x I think then? Is your team publishing its work to github...

@bmeynell This library is a total mess. :smile: It does not throw exceptions at all. You have to "ask" the client if there was an error on an boolean var....