nap icon indicating copy to clipboard operation
nap copied to clipboard

feat: vim binds for right-left

Open jolheiser opened this issue 1 year ago • 5 comments

Resolves #52

The bubble List type already has default keys that respect j and k, so this PR simply adds h and l for navigating panes.

jolheiser avatar Jun 01 '23 15:06 jolheiser

I think we should probably use capital H and L since h and l will navigate through the pages if there are lots of snippets in the list.

maaslalani avatar Jun 01 '23 15:06 maaslalani

Ah, I missed that when checking the default keys.

We already use L for something else, so that may not work here, and I think it may be more confusing to have two upper case and two lower case for "navigation".

I guess it comes down to this app vs the generic List bubble, what do you think makes more sense?

  1. Using this PR as general navigation and instead changing the keybinds for list paging?
  2. Changing L to something else and using all uppercase for movement
  3. Some toggle for "vim mode" that toggles between 1 above and how it works today.
  4. Something else entirely

jolheiser avatar Jun 01 '23 15:06 jolheiser

I think generally the changing folder, file name, file extension is confusing. I believe ideally instead of separate key bindings for each we should have one key binding and then tab between the different options. What do you think? We can even replace L (for language) with E for extension.

maaslalani avatar Jun 01 '23 15:06 maaslalani

I'm gonna get into the weeds a bit now I think, but overall folder as a collection almost seems more suited for tags. Which leaves file and extension renaming, which I agree could be a single key to change the whole file name.

In regards to this PR specifically, even changing L so we can reuse it for vim-like bindings, I think it would be better to have all "general navigation" be the same type case, eg hjkl or HJKL At least imo pane navigation is probably more expected than list paging for left and right.

jolheiser avatar Jun 01 '23 15:06 jolheiser

Consider changing the keybinding of the more obscure page navigation. If j/k work, you expect h/l to work. You certainly don't expect j/k/H/L. Consider n/p for pages?

transcendr avatar Feb 12 '24 08:02 transcendr