invoice icon indicating copy to clipboard operation
invoice copied to clipboard

Make quantity a floating point number not an integer.

Open rouilj opened this issue 1 year ago • 6 comments

For invoices that bill by time, --quantity should be a floating point number so 1/2 hour or other time periods can be specified. Currently using --quantity 0.5 --rate 175 I get:

2023/07/03 23:32:17 invalid argument "0.5" for "-q, --quantity" flag: strconv.Atoi:
  parsing "0.5": invalid syntax

for invoicing a 1/2 hour call.

Thanks.

rouilj avatar Jul 03 '23 23:07 rouilj

@rouilj until this is fixed, you can change your rate on items that are qty < 1 to match, for e.g. -q 1 -r 87.5 since -r or --rates DOES support floating/decimals. Then, in the item notes, in parens, you can say (1/2 hrs @ $175/hr = $87.50). Just a work around.

pyrite357 avatar Jul 12 '23 19:07 pyrite357

In message @.***>, Yoseph Tanner writes:

@rouilj until this is fixed, you can change your rate on items that are qty < 1 to match, for e.g. -q 1 -r 87.5 since -r or --rates DOES support floating/decimals.

Yes that works. However explaining to somebody that the 1/2 hour phone call was billed as an hour phone call at 1/2 the rate is not something I want to deal with.

-- -- rouilj John Rouillard

My employers don't acknowledge my existence much less my opinions.

rouilj avatar Jul 12 '23 19:07 rouilj

@rouilj you may have responded before I edited my response and added this part Then, in the item notes, in parens, you can say (1/2 hrs @ $175/hr = $87.50). Just a work around.

But trust me, I'm with you on this, take a look at #31 , I said the same things ;)

pyrite357 avatar Jul 12 '23 20:07 pyrite357

@rouilj I posted a patch in #31 , you can use go build (if you don't already know) to build it

pyrite357 avatar Jul 13 '23 21:07 pyrite357

I actually decided to give a shot to learning a little go. So I have my own change for it. But thanks for the pointer. I'll use your pointer to see if my change is idiomatic go.

rouilj avatar Jul 13 '23 23:07 rouilj

I actually decided to give a shot to learning a little go. So I have my own change for it. But thanks for the pointer. I'll use your pointer to see if my change is idiomatic go.

LOL, me too. Today is my first day ever writing any GO code. Take a look at #31 I just submitted code for implementing version command, Chinese char support,and the qty change.

pyrite357 avatar Jul 13 '23 23:07 pyrite357