MPSKit.jl icon indicating copy to clipboard operation
MPSKit.jl copied to clipboard

Dedicated `approximate` method for variational truncation of an `AbstractMPS`

Open leburgel opened this issue 1 year ago • 1 comments

It might be useful to add a dedicated approximate(Ψ₀::AbstractMPS, Ψ::AbstractMPS, algorithm, [environments]; kwargs...) method for a globally optimal truncation of a given MPS. It is mentioned in the changebonds documentation that combining changebonds(Ψ::AbstractMPS, alg::SvdCt) with approximate can give a globally optimal truncation, but as far as I can tell all current implementations of approximate take an MPO-MPS pair as the object to approximate, so I don't see how this could be done directly.

leburgel avatar Nov 30 '23 09:11 leburgel

To tag on to this, should we change the approximate call signature to not take in tuples? I'm not sure why I started doing that, but at the moment it certainly doesn't look so clean

maartenvd avatar Dec 18 '23 08:12 maartenvd