ma1sd icon indicating copy to clipboard operation
ma1sd copied to clipboard

Change systemd definition to log to file rather than syslog

Open the-moog opened this issue 5 years ago • 5 comments

As per issue #20

the-moog avatar Jan 27 '20 12:01 the-moog

I think the changes are correct but I don't yet have a test environment to prove it.

the-moog avatar Jan 27 '20 12:01 the-moog

Thanks for PR, but I don't think that it's a great idea. May be some one want write logs to the syslog. Also you don't need to specify the -v option because starting from 2.3.0 version you can configure log level in the configuration.

ma1uta avatar Feb 06 '20 20:02 ma1uta

I would disagee. Syslog for the the system not one service on the system. Spamming syslog with messages from every service masks issues that affect the system as a whole. Synapse uses it's own logfile. IMO let the users decide it's not my system or yours so each will have their own requirements. Add a logfile option which can be one of STDOUT or file or STDERR or pipe, etc.

the-moog avatar Feb 07 '20 09:02 the-moog

It's a good idea to let the user decide where to write the log. Default however should be syslog.

bpcurse avatar Feb 08 '20 11:02 bpcurse

Ok, I see you. I can offer the next solution: current behavior remains without changes but I'll add the configuration option to configure logger, it may be STDOUT, file or remote networt port. Additionally admins can configure the logger to be asynchonous for example.

ma1uta avatar Feb 09 '20 12:02 ma1uta