jmsdk icon indicating copy to clipboard operation
jmsdk copied to clipboard

Bump dependencies and new release?

Open brevilo opened this issue 3 years ago • 18 comments

Hi!

Development seems to be paused right now. Could you please consider bumping the dependencies again and push another release so that the latest version is available via maven?

Thanks and keep it up!

brevilo avatar Mar 18 '21 09:03 brevilo

Ideally containing the fix for #18 😏

brevilo avatar Mar 21 '21 21:03 brevilo

Speaking of dependencies, even while mostly unrelated to this issue...

Here's a little FYI for everyone trying to deploy this in an OSGi environment: you need at least version 2.0.1-RC1 of the microprofile-rest-client-api or the runtime deployment won't work (due to unresolvable dependencies on CDI and MircoProfile Config).

Hope this helps

brevilo avatar Mar 31 '21 17:03 brevilo

I have plan to bump dependencies, yes. I think I can do this in a few weeks, sorry for delay.

ma1uta avatar Apr 03 '21 19:04 ma1uta

No worries, I have another PR coming (needed for OSGi compatibility). Hope to get it done later today.

brevilo avatar Apr 05 '21 09:04 brevilo

Also, there might might be another bugfix required for microprofile-rest-client-api so holding off is actually a good thing right now. I'll keep you posted if and when things got resolved.

brevilo avatar Apr 05 '21 09:04 brevilo

No worries, I have another PR coming (needed for OSGi compatibility). Hope to get it done later today.

There you go: #20

brevilo avatar Apr 05 '21 13:04 brevilo

I'm also interested in this for https://github.com/ma1uta/jmsdk/pull/11

blakehawkins avatar Apr 12 '21 20:04 blakehawkins

Also, there might might be another bugfix required for microprofile-rest-client-api so holding off is actually a good thing right now. I'll keep you posted if and when things got resolved.

This needs some further work. So if you want to bump deps and release, please go ahead. Please remember to update the rest client as described above.

brevilo avatar Apr 14 '21 19:04 brevilo

Done in https://github.com/ma1uta/jmsdk/commit/f3c8bed45a7b3deeff10f8532dcbb71376dedd1c I'm going to publish release.

ma1uta avatar Apr 14 '21 20:04 ma1uta

I use microprofile 3.3: https://github.com/ma1uta/jmsdk/blob/master/jmsdk-bom/pom.xml#L58

ma1uta avatar Apr 14 '21 20:04 ma1uta

Ah, right. Well, in that case I need to maintain my own fork for the time being. Even the latest microprofile (4.0.1) still provides only microprofile-rest-client-api 2.0, for obvious reasons.

I'll close this issue. I'll ask for a microprofile bump when they released a version that includes the rest API >= 2.0.1. That's probably going to take a while.

Thanks

brevilo avatar Apr 15 '21 08:04 brevilo

Ok, I'll reopen until 0.13.0 is actually released 😎 (please do)

brevilo avatar Apr 20 '21 17:04 brevilo

I'm trying but stuck on error when building the master:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.0:compile (default-compile) on project jackson-support: Compilation failure
[ERROR] ~/dev/jmsdk/jackson-support/src/main/java/module-info.java:[31,52] module not found: com.fasterxml.jackson.jaxrs.json

I think I'll fix this. Update: have created an issue https://github.com/FasterXML/jackson-jaxrs-providers/issues/144 of the jackson.

ma1uta avatar Apr 20 '21 20:04 ma1uta

Yep, I've also been looking into this and couldn't find a solution.

FYI, glad you updated MapStruct to >= 1.4.0 since they had an issue with Java 11 modules (java.sql.Date missing).

brevilo avatar Apr 21 '21 06:04 brevilo

About the Jackson issue: since things aren't getting fixed upstream, how about reverting the earlier version bump from 2.12.3 back to 2.11.2? I think I could confirm 2.12.0-rc2 as being the culprit, so the latest in the 2.11 series, i.e. 2.11.4 should also be fine.

This way we could get things going again, in particular now that Jeon 0.13.0 got released, meaning API's versions are out of sync with jmsdk now.

brevilo avatar May 22 '21 17:05 brevilo

Ok, I have release 0.13.1 (jeon and jmsdk) with jackson 2.11.4, please see, does it works?

ma1uta avatar May 26 '21 11:05 ma1uta

Yep, works for me. Should we open a issue to remind ourselves about the pending upstream issue, or keep this one open?

brevilo avatar May 26 '21 19:05 brevilo

As you wish :)

ma1uta avatar May 27 '21 06:05 ma1uta