mCRL2 icon indicating copy to clipboard operation
mCRL2 copied to clipboard

Qt 6.7 added a Windows 11 theme, which enabled dark mode, and this makes the icons hard to see in mcrl2ide

Open mlaveaux opened this issue 10 months ago • 1 comments

This is mCRL2ide compiled with Qt 6.7. Although the icons are also the same for macOS dark mode it seems to me like the background is darker, thus making it hard to see them.

image

Whereas the nightly version, using Qt 6.6, looks fine:

image

mlaveaux avatar Apr 09 '24 15:04 mlaveaux

Yep they added dark mode but still there is no simple way to detect these changes. https://github.com/search?q=repo%3Aqt%2Fqtbase%20colorSchemeChanged&type=code Their signal colorSchemeChanged never emits by Qt developers, none QPA plugins emits it if I understand correctly.

krab avatar May 04 '24 00:05 krab

Currently, we do not have suitable icons for the Windows dark mode palette. So my proposed solution would be to set windows:darkmode=0 on startup to disable dark mode on Windows completely for the time being.

mlaveaux avatar May 21 '24 13:05 mlaveaux

I could make some icons suitable for light mode. Concerning detection of dark mode, I can remember adding basic code for that, for instance for the text editor syntax colouring, that simply checks whether the background is dark and if so, uses dark mode defaults. I guess the same thing can be done here.

Valo13 avatar May 21 '24 13:05 Valo13

If you want to make icons for light than that could work as well for mcrl2ide. Perhaps for ltsgraph it might still be useful to disable dark mode due to the white canvas. Also my proposed solution does not work for the menus for whatever reason.

image

mlaveaux avatar May 21 '24 13:05 mlaveaux

I figured out how to disable the dark mode completely for the moment, when the dark icons are ready (and perhaps some other styling) it can be enabled properly.

mlaveaux avatar Jun 10 '24 11:06 mlaveaux

The issue has been fixed, icons can be added in a separate issue/pull request.

mlaveaux avatar Jul 02 '24 08:07 mlaveaux