telegram-bot-client icon indicating copy to clipboard operation
telegram-bot-client copied to clipboard

Some additional client Methods

Open tibebeselasie-mehari opened this issue 7 years ago • 4 comments

tibebeselasie-mehari avatar Aug 13 '18 07:08 tibebeselasie-mehari

Hey, thanks for opening this. The failing tests seem to be my bad as Travis does not pick up the Telegram credentials needed for testing correctly on your fork (which I thought it would).

Let me check that real quick.

m90 avatar Aug 13 '18 07:08 m90

It looks like the feature got disabled:

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#Pull-Requests-and-Security-Restrictions

so we'll have to live with the failing tests here for now unfortunately.

m90 avatar Aug 13 '18 07:08 m90

It's a bit unfortunate that you are unable to run them on Travis right now, but would you be interested in also adding tests for the newly added methods? It's a pretty straightforward thing and helps a lot.

m90 avatar Aug 13 '18 07:08 m90

I migrated master to use eslint and merged the changes into your branch so that it's not too much of a hassle to pick it up again.

m90 avatar Aug 30 '18 10:08 m90