M5Atom icon indicating copy to clipboard operation
M5Atom copied to clipboard

Remove blocking semaphore, display initial state and allow large matrix

Open brice-fr opened this issue 4 years ago • 3 comments

Actual library LED_Display animations are not working due to blocking semaphore The initial state (offset 0,0) of the buffer is never displayed in animations Large buffer matrix can not be displayed or wrapped around due to limited offset type Various minor english typo corrections

brice-fr avatar May 04 '20 08:05 brice-fr

So this is months old, why hasn't someone from M5Stack at least commented on this? Merge it?

johnwargo avatar Aug 25 '20 22:08 johnwargo

Wish I'd seen this earlier - I suspected a major bug in the animation code and was confused by the use of a semaphore. I wrote my own horizontal scroller logic (which is all I needed) to work around the issues in my own project Atomic Text.

I'm somewhat shocked too that this hasn't been merged in either or the Atom library itself updated since January.

KodeMunkie avatar Oct 26 '20 15:10 KodeMunkie

Hi, can you please enable Allow edits from maintainers, I need to format the code.

Tinyu-Zhao avatar Aug 29 '22 08:08 Tinyu-Zhao