Mokhtar
Mokhtar
This issue is no longer needed, the bug has been fixed with the recent archv3 changes merged to master. See [commit b31ee370a9f055433dd26eb7229da8ceb3743d9e](https://github.com/medic/cht-core/commit/b31ee370a9f055433dd26eb7229da8ceb3743d9e#diff-dd6632d3132a5c703c567d9fd5c5d8dca9974b5b6d3103d33bc9dd8922758d49)
@jkuester I completely resolved the conflicts we had with `master`, could you take a look to make sure I haven't broken anything in the process? :joy: thankfully the tests we...
@latin-panda could you please review it?
This PR is no longer needed, the bug has been fixed with the recent archv3 changes merged to master. See [commit b31ee370a9f055433dd26eb7229da8ceb3743d9e](https://github.com/medic/cht-core/commit/b31ee370a9f055433dd26eb7229da8ceb3743d9e#diff-dd6632d3132a5c703c567d9fd5c5d8dca9974b5b6d3103d33bc9dd8922758d49)
If I understand correctly, any report submitted after the replace will automatically appear to be submitted by the new contact, that's neat! I love where this is going :star_struck:
@jkuester I went ahead and added one more commit to simplify even more some return types, other than that it's looking very good!
Hey, any update here? I'd *love* to see this working in the browser
@jkuester @mrjones-plip I went ahead and implemented solution `#2` because I would need a few more days to implement `#3` properly with its associated tests. If that's okay, [the PR](#7847)...
Quick recap of what happened so far: - Both patches are now removed - ~~[Logic for pausing multimedia when switching pages](https://github.com/medic/cht-core/commit/772a4feac360e8265af15b1fe7292b47ba2f0649)~~ removed in the [uplift PR](https://github.com/medic/cht-core/pull/8528) - ~~[Patch for Enketo...
Great work there! Thanks for catching the `readFileSync` issue :+1: Let me know when you feel like I can merge your work