ILGPU icon indicating copy to clipboard operation
ILGPU copied to clipboard

Added metapackage containing all ILGPU libraries.

Open MoFtZ opened this issue 3 years ago • 5 comments

Not sure if we want this meta-package or not, but might be useful. Also not sure about the name.

MoFtZ avatar Oct 14 '21 03:10 MoFtZ

Great idea @MoFtZ!

For the name, I would suggest renaming ILGPU to ILGPU.Core, and naming the meta-package ILGPU. This would mean a breaking change and thus something we would plan for 2.0.

Thoughts?

jgiannuzzi avatar Oct 14 '21 12:10 jgiannuzzi

@MoFtZ I really like this idea 👍

I have to admit that I prefer @jgiannuzzi's idea of creating a "new" ILGPU package instead of an ILGPU.All package.

m4rs-mt avatar Oct 14 '21 16:10 m4rs-mt

@jgiannuzzi @m4rs-mt I agree that the name ILGPU.All is not great. However, I was trying to avoid a breaking change. Also, it matched some existing names like Microsoft.AspNetCore.All.

I'll put this PR on hold until we decide on a timeframe (and name?).

MoFtZ avatar Oct 17 '21 11:10 MoFtZ

Something else to consider, if we rename ILGPU to ILGPU.Core, are we only renaming the nuget package? Or all the files/folders?

That would include:

  • Src/ILGPU to Src/ILGPU.Core
  • Src/ILGPU.Tests to Src/ILGPU.Core.Tests
  • etc

MoFtZ avatar Oct 18 '21 06:10 MoFtZ

Renames the ILGPU nuget package to ILGPU.Core. Adds a new ILGPU metapackage.

Depends on #718.

MoFtZ avatar Dec 23 '21 22:12 MoFtZ

Abandoning this PR.

In the future e.g. v2, it will be easier to deprecate ILGPU.Algorithms and release the ILGPU package with ILGPU.Algorithms baked in.

MoFtZ avatar Feb 08 '23 01:02 MoFtZ