ILGPU icon indicating copy to clipboard operation
ILGPU copied to clipboard

[FEATURE REQUEST]: Improve check-required workflow

Open pavlovic-ivan opened this issue 1 year ago • 7 comments

Is your feature request related to a problem? Please describe.

N/A

Describe the solution you'd like

In several other repos we maintain (like Parquetsharp, FML, YHS, Armada), we have the latest version of check-required workflow. This version is a bit more advanced than the currently existing one in ILGPU. I would like to contribute with the improvement of this workflow, so i can, later on, extract it to a common repo, where it would be centralised, and updated regularly, so everyone receives the latest version

Describe alternatives you've considered

No response

Additional context

No response

pavlovic-ivan avatar Jul 01 '24 11:07 pavlovic-ivan

@MoFtZ @m4rs-mt how do you feel about this request?

pavlovic-ivan avatar Jul 01 '24 11:07 pavlovic-ivan

Sounds like a good idea @pavlovic-ivan 👍 Especially if it makes your life easier.

MoFtZ avatar Jul 01 '24 11:07 MoFtZ

All right, happy to hear that. I will create a PR for you soon

pavlovic-ivan avatar Jul 01 '24 11:07 pavlovic-ivan

There will be some setup required in the settings, if that's ok with you @MoFtZ ? Basically, a Github app needs to be created, and it's app id and private key should be added as secrets to ILGPU settings.

pavlovic-ivan avatar Jul 01 '24 11:07 pavlovic-ivan

There will be some setup required in the settings

This will need to be handled by @m4rs-mt 🥰

MoFtZ avatar Jul 01 '24 11:07 MoFtZ

I'm back and happy to do what is required in the next days! Will connect with you offline to get things going @pavlovic-ivan

m4rs-mt avatar Jul 18 '24 20:07 m4rs-mt

Sounds good @m4rs-mt , let's sync offline

pavlovic-ivan avatar Jul 19 '24 07:07 pavlovic-ivan