Marc Foley

Results 158 comments of Marc Foley

I think I'm going to put my refactoring work in #397 on hold until we've got this issue sorted. It may make sense to talk about it in tomorrow's meeting....

I've started drafting a UML diagram for this issue, https://drive.google.com/file/d/1C84Ghabaz7hI1bHlnhCbcOWmhA3O2WQl/view?usp=sharing. Let's work on it in today's meeting.

Apologies for not reviewing this. I'll cut a release and look at this next week.

Thanks for the pr. Unfortunately, I think the current implementation is correct. I've implemented something similar in fonttools-rs and copied the current implementation here due to the following comment/thread, https://github.com/googlefonts/fontbakery/issues/2672#issuecomment-722027792

+1 to tests. Please also look at how the fonts perform on a browser which uses GDI since our current implementation is optimised for this.

Getting there slowly. Linux and Win execs can now be built and attached to the release.

This will still fail for certain combos such as ``` >>> strip_accents("Ǽplas").isascii() False ```

> Is this designer directory exposed to the public anywhere? Designer dirs are here https://github.com/google/fonts/tree/main/catalog/designers > How is it used? Each directory contains the metadata for each font author. If...

@simoncozens After emailing the eng team, it seems like we're stuck with ascii folder names and we can only have Latin names. Due to these requirements, I'm going to do...