rubocop-git icon indicating copy to clipboard operation
rubocop-git copied to clipboard

Published 20 hours ago • verified publisher icon m4i

Do not include violations that don't have any offenses

Open stewartpark opened this issue 6 years ago • 1 comments

The rubocop-git command exits with exit code 1, but the console output says no offenses.

This is because it doesn't display disabled offenses, and if all offenses are disabled under a violation, it just says there are no offenses. But when it determines whether it should exit(1), it just sees if there are any violations.

stewartpark avatar Jul 05 '18 20:07 stewartpark

I'll go ahead and second this PR. We use rubocop-git for CI build checks, on only changed code. This issue causes it to fail on seemingly no offenses.

And can confirm this change fixes our issue. @m4i any chances this will make it in?

seanbjornsson avatar Apr 16 '19 17:04 seanbjornsson