scroll icon indicating copy to clipboard operation
scroll copied to clipboard

Design for StrCtx that takes delimiter or maximum size

Open m4b opened this issue 4 months ago • 0 comments

See initial discussion in https://github.com/m4b/scroll/issues/108#issuecomment-3217055258

We may want to change behavior of DelimiterUntil, but probably more likely we'd add a ctx with this behavior.

Here are the only uses of DelimiterUntil in goblin:

src/pe/symbol.rs
207:                .pread_with(offset, ctx::StrCtx::DelimiterUntil(0, 8))
466:            .pread_with(offset, ctx::StrCtx::DelimiterUntil(0, length))

Either way it's a breaking change since we don't have non-exhaustive on StrCtx.

cc @kkent030315

m4b avatar Aug 23 '25 19:08 m4b