goblin icon indicating copy to clipboard operation
goblin copied to clipboard

Check if an entry in the TLS callback list is the terminator before trying to load it

Open gabrielesvelto opened this issue 1 year ago • 4 comments

This fixes issue #412.

gabrielesvelto avatar Jun 11 '24 13:06 gabrielesvelto

Sure, I'll try to add it.

gabrielesvelto avatar Jul 02 '24 09:07 gabrielesvelto

let me know if you have a test case ready, or if you can modify an existing one that shows this change won't add any regressions, etc. thanks!

m4b avatar Jul 21 '24 04:07 m4b

let me know if you have a test case ready, or if you can modify an existing one that shows this change won't add any regressions, etc. thanks!

Yeah, I'll add a test here and provide a fix for issue #412 too later this year. I've been caught up in other stuff but I'll try to come back to this ASAP.

gabrielesvelto avatar Jul 21 '24 13:07 gabrielesvelto

@gabrielesvelto no worries, just doing some triage this weekend/poking people :)

m4b avatar Jul 21 '24 19:07 m4b

@gabrielesvelto thank you for this patch; it turns out this was re-discovered and fixed in another patch #425 fixing some recent tls stuff breaking on rust produced binaries, but thank you for your contribution and sorry we didn't merge it earlier :)

m4b avatar Oct 26 '24 06:10 m4b

np, glad it's fixed!

gabrielesvelto avatar Oct 26 '24 06:10 gabrielesvelto