goblin icon indicating copy to clipboard operation
goblin copied to clipboard

Version 0.8.1 includes a breaking change

Open nox opened this issue 3 months ago • 0 comments

Adding feature te to if_everything is a breaking change that causes cargo-deny 0.4.22 to not build anymore.

cargo-deny depends on goblin 0.8 with a specific set of features and with default-features disabled

# Native executable detection
goblin = { version = "0.8", default-features = false, features = [
  "elf32",
  "elf64",
  "mach32",
  "mach64",
  "pe32",
  "pe64",
] }

It then uses goblin::peek_bytes.

For peek_bytes to be enabled in goblin 0.8.1, cargo-deny now needs to enable feature "te":

https://github.com/m4b/goblin/blob/f025d4995d83c17e5df9d50d2567fe0a06926d83/src/lib.rs#L238-L248

Please yank 0.8.1 and re-release as 0.9.0.

nox avatar Apr 29 '24 08:04 nox