impress.js-progress icon indicating copy to clipboard operation
impress.js-progress copied to clipboard

Integrated impress.js-progress in my impress.js fork

Open henrikingo opened this issue 7 years ago • 0 comments

Hi Matthias

I've been contributing to impress.js for the past year or so.

I just wanted to let you know that I have added your progress bar to my fork of impress here: https://github.com/henrikingo/impress.js

The new thing is that we're adding (well, it's only in my repo at the moment...) a plugin API so that new features can be added in a modular way. It turns out impress.js-progress was written in the same way as the API mostly does it too, by using the events triggered by core impress.js. So it was straightforward to add your code with minor changes. (I extended the impress:stepleave event instead of adding impress:starttransition, in an effort to minimize additions to the core.)

The main benefit for a user of impress.js-progress is that you don't need to use a separate <script> tag to include a separate js file any longer. Just adding the <div> in your presentation will do the magic.

I also modified the sample CSS slightly to make the bar and digits smaller. You can watch a demo here: http://henrikingo.github.io/impress.js/examples/classic-slides/

One question: Can you confirm your code is MIT licensed, like the core impress.js? If yes, I would appreciate if you also added a mention of MIT license to the README in this repo, so there's no ambiguity.

henrikingo avatar Jul 17 '16 20:07 henrikingo