Michael Maltsev
Michael Maltsev
Thanks, looks good overall. Please extract the functionality to a separate function. > * could be confused if `` are appearing anywhere but in tag endings That's OK, it's not...
> In my testing I used an example like this: If you saw it in an actual website, then it's fine, let's keep it. But now that I think about...
This is actually more tricky than I thought. For RSS, it seems that text inside CDATA has to be decoded once, but text outside of CDATA has to be decoded...
> But is this a somewhat common use for the end user of this Windhawk Mod? Who wants e.g. & as undecoded text from an otherwise decoded websource inside of...
From what I understand, `HtmlUtilities` doesn't require valid HTML or tags to be closed. The crash is not a good sign, I'll take a look later to try and find...
I checked the crash, and indeed it's the one you linked. Unfortunately I don't think it has an easy solution. `HtmlUtilities::ConvertToText` uses an IE/Edge module under the hood. This module...
> There were quite a lot of workarounds needed for it to run reliably on most Windows machines. What do you mean? What kinds of workarounds? > The dependency IE11...
I didn't have time to look at it in depth. I didn't quite understand why `CLSID_HTMLDocument` can't be used, i.e. does using it not compile, or does it work only...
> ```c++ > const CLSID CLSID_HTMLDocument = {0x25336920, 0x03F9, 0x11CF, {0x8F, 0xD0, 0x00, 0xAA, 0x00, 0x68, 0x06, 0xFA}}; > ``` This definition is incorrect (last two numbers), here's how it's...
Thank you, I might make some minor follow-up changes to your code, but it looks good now, more manageable and more robust than the previous iterations. Regarding additional search-replace rules,...