m3 icon indicating copy to clipboard operation
m3 copied to clipboard

[dbnode] - Add filesystem available space reporting

Open shrek opened this issue 3 years ago • 2 comments

What this PR does / why we need it: Fixes #3400 Please refer to the discussion in the issue. In summary, this PR adds metrics for available space in the filesystem, and the sizes of files in different m3db directories. It can be used to alert on filesystem available space thresholds. The added metrics look like this:

# TYPE filesystem_avail_bytes gauge
filesystem_avail_bytes 4.2259341312e+10
# HELP filesystem_commitlogs_bytes filesystem_commitlogs_bytes gauge
# TYPE filesystem_commitlogs_bytes gauge
filesystem_commitlogs_bytes 40
# HELP filesystem_data_bytes filesystem_data_bytes gauge
# TYPE filesystem_data_bytes gauge
filesystem_data_bytes 66304
# HELP filesystem_index_bytes filesystem_index_bytes gauge
# TYPE filesystem_index_bytes gauge
filesystem_index_bytes 4310
# HELP filesystem_num_dir_api_errors filesystem_num_dir_api_errors counter
# TYPE filesystem_num_dir_api_errors counter
filesystem_num_dir_api_errors 1.829242e+06
# HELP filesystem_num_fs_api_errors filesystem_num_fs_api_errors counter
# TYPE filesystem_num_fs_api_errors counter
filesystem_num_fs_api_errors 0
# HELP filesystem_snapshots_bytes filesystem_snapshots_bytes gauge
# TYPE filesystem_snapshots_bytes gauge
filesystem_snapshots_bytes 1.8173384e+07
# HELP filesystem_total_bytes filesystem_total_bytes gauge
# TYPE filesystem_total_bytes gauge
filesystem_total_bytes 6.2725623808e+10

Special notes for your reviewer:

Does this PR introduce a user-facing and/or backwards incompatible change?:

NONE

Does this PR require updating code package or user-facing documentation?:

NONE

shrek avatar Apr 25 '21 20:04 shrek

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Apr 25 '21 20:04 CLAassistant

Codecov Report

Merging #3450 (837f895) into master (1843061) will decrease coverage by 8.0%. Report is 591 commits behind head on master. The diff coverage is 89.8%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #3450     +/-   ##
=========================================
- Coverage    72.4%    64.4%   -8.0%     
=========================================
  Files        1100     1100             
  Lines      102443   101703    -740     
=========================================
- Hits        74203    65579   -8624     
- Misses      23143    31312   +8169     
+ Partials     5097     4812    -285     
Flag Coverage Δ
aggregator 69.6% <ø> (-7.3%) :arrow_down:
cluster 65.7% <ø> (-19.2%) :arrow_down:
collector 84.3% <ø> (ø)
dbnode 75.6% <71.4%> (-3.4%) :arrow_down:
m3em 68.6% <ø> (-5.8%) :arrow_down:
m3ninx 62.8% <ø> (-10.8%) :arrow_down:
metrics 19.8% <ø> (ø)
msg 74.4% <ø> (+<0.1%) :arrow_up:
query 52.5% <ø> (-14.6%) :arrow_down:
x 63.3% <91.9%> (-17.3%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1843061...837f895. Read the comment docs.

codecov[bot] avatar Sep 11 '23 10:09 codecov[bot]