m3 icon indicating copy to clipboard operation
m3 copied to clipboard

[dbnode] Validate index segments and properly mark fulfilled ranges

Open notbdu opened this issue 4 years ago • 1 comments

What this PR does / why we need it:

Validate and remove corrupted index segments. Only mark fulfilled ranges for default index volume type persisted blocks.

Also adds an additional test to cover bootstrapping partial shards in index segments. This is the node leave case where the peers bootstrapper fetches and persists data for additional shards and crashes before writing index data to disk.

Special notes for your reviewer:

Does this PR introduce a user-facing and/or backwards incompatible change?:

NONE

Does this PR require updating code package or user-facing documentation?:

NONE

notbdu avatar Dec 09 '20 06:12 notbdu

Codecov Report

Merging #2995 (e3e33da) into master (37665c0) will increase coverage by 0.0%. Report is 906 commits behind head on master. The diff coverage is 74.3%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #2995    +/-   ##
=======================================
  Coverage    72.3%   72.3%            
=======================================
  Files        1078    1078            
  Lines       99413   99537   +124     
=======================================
+ Hits        71914   72022   +108     
- Misses      22509   22519    +10     
- Partials     4990    4996     +6     
Flag Coverage Δ
aggregator 75.9% <ø> (ø)
cluster 85.2% <ø> (+0.1%) :arrow_up:
collector 84.3% <ø> (ø)
dbnode 78.8% <74.3%> (-0.1%) :arrow_down:
m3em 74.4% <ø> (ø)
m3ninx 73.1% <ø> (-0.1%) :arrow_down:
metrics 19.9% <ø> (ø)
msg 74.1% <ø> (+0.5%) :arrow_up:
query 67.4% <ø> (ø)
x 80.2% <ø> (+<0.1%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 37665c0...e3e33da. Read the comment docs.

codecov[bot] avatar Sep 11 '23 10:09 codecov[bot]