m3
m3 copied to clipboard
Replace github.com/golang/protobuf/proto with github.com/gogo/protobuf/proto
What this PR does / why we need it:
A global find/replace of github.com/golang/protobuf/proto with github.com/gogo/protobuf/prototo avoid incompatibility surprises (previously there was a mix of the two being used, and we are actually generating protobuf with gogo).
Special notes for your reviewer: Adding a lint rule against future occurrences in https://github.com/m3db/m3/pull/2766.
Does this PR introduce a user-facing and/or backwards incompatible change?: NONE
Does this PR require updating code package or user-facing documentation?: NONE
Codecov Report
Merging #2767 (848d255) into master (57353bc) will decrease coverage by
26.9%. Report is 885 commits behind head on master. The diff coverage isn/a.
Additional details and impacted files
@@ Coverage Diff @@
## master #2767 +/- ##
=========================================
- Coverage 72.3% 45.5% -26.9%
=========================================
Files 1080 214 -866
Lines 99481 18502 -80979
=========================================
- Hits 71975 8420 -63555
+ Misses 22518 9408 -13110
+ Partials 4988 674 -4314
| Flag | Coverage Δ | |
|---|---|---|
| aggregator | 55.8% <ø> (-20.0%) |
:arrow_down: |
| cluster | ∅ <ø> (∅) |
|
| collector | 54.3% <ø> (-30.0%) |
:arrow_down: |
| dbnode | ? |
|
| m3em | 46.4% <ø> (-28.0%) |
:arrow_down: |
| m3ninx | ? |
|
| metrics | 19.8% <ø> (ø) |
|
| msg | 74.1% <ø> (-0.2%) |
:arrow_down: |
| query | ? |
|
| x | ? |
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 57353bc...848d255. Read the comment docs.