Kelvin Glaß

Results 36 comments of Kelvin Glaß

@FKHals Hi, great to see that someone is working on the build and dependency stuff 👍 I think my main idea was that the core is a just a library...

@FKHals It seems like you are using the CI for executing the STF tests. You can also execute them on your local Linux machine with `./run_stf.sh` (needs docker and the...

> It is mainly an issue with the deployment. If you update the bundle you also have to ensure that Eclipse will install it (so basically update the version number...

I would add: * AbstractClassWithoutAbstractMethod * SystemPrintln (I assume we have to ignore the rule in Saros.java and probably the server) * UseTryWithResources * ForLoopCanBeForeach * UseCollectionIsEmpty There are also...

> The question is what our aim with the new ruleset is. Do we want to keep as many rules from the best practices section as possible or do we...

In order to use a consistent version number in the metafiles (as the Manifest and plugin.xml which provide additional information for the IDEs) as well as in our internal version...

Maybe my explanation was not very clear: > We have to be careful the version in SAROS_VERSION is not the version of the server. It is the eclipse version that...

@tobous We alredy implemented a similar solution for our nightly builds. What do you think is missing to re-use this approach to fix this issue?

> local builds might not always have access to a git instance This is only the case if someone would download the project as zip. However, we could use the...

I created a small test commit and found the following TODOs: * Add a workaround if the .git directory is missing (see [here](https://github.com/palantir/gradle-git-version/issues/327)). This is simple but ugly (add the...