xmrwallet
xmrwallet copied to clipboard
m2049r
Add Arabic Translation !
Translated and Added:
- values-ar/
- about.xml
- help.xml
- strings.xml
By following the translation guide, Tested and ready for merge!
Bruh this is a meme translation.
بص وراك
انا امن اشطاا
This is Egyptian not Arabic.
@jermanuts thanks for reviewing my work, I'm a native speaker with Egyptian accent Lines mentioned were intentionally wrote in Egyptian accent, As i thought it would be more clear explaining/Getting user attention in important warnings, I tested it with real people around and it was fine
I'm happy to edit these if you think it would interrupt with the user understanding of important stages of the wallet
I'm happy to edit these if you think it would interrupt with the user understanding of important stages of the wallet
Sure.
@jermanuts would be awesome if you reviewed again, i fixed some lines Thanks.
@Justxd22 Add spacing, you removed spaces between lines, see the original https://github.com/m2049r/xmrwallet/blob/master/app/src/main/res/values/strings.xml
معرف
معرّف do all
أنفاق مونيرو الحلو الخاصة بي
مونيروجو Like in the original string
لصق
ألصق
العقد، في الطريق
العقد، على طريقتك
Translate Tor to تور , Monero to مونيرو and Monerujo to مونيروجو be consistent
Also you didn't change the about.xml file, monerujo is transliterated to مونيروجو only once then monerujo is used instead of the transliteration.
@m2049r Can we transliterate monerujo? because it breaks RTL when used at the beginning of any sentences like
Can we transliterate monerujo? because it breaks RTL when used at the beginning of any sentences like
@anhdres please review this - esp. the comment above
I'd transliterate Monerujo, specially if it improves the way a user may refer to it verbally, because transliterating it should preserve that.
If it were only for the left vs right layout I'd just add a word in Arabic before Monerujo (that makes sense, of course) and solve it that way.
@m2049r The only use case where literal Monerujo needs to be preserved (I'm guessing) is in the legal text, because I assume it should match perfectly with the name of the app.
According to Google, seems like a fair transliteration:
Yep, like Monero, the transliteration for it in Arabic is more popular, also with Tor. مونيرو and تور.
@Justxd22 lets translate all instances of Monerujo to مونيروجو except the legal stuff, append the original name and the Arabic transliteration afterwards to preserve RTL. Like:
مونيروجو (Monerujo) ................................................
@Justxd22 lets translate all instances of Monerujo to مونيروجو except the legal stuff, append the original name and the Arabic transliteration afterwards to preserve RTL. Like:
مونيروجو Monerujo ................................................
Perfect, do it the way you need (left or right) so that it doesn't break the layout again. You can put (Monerujo) between brackets for example.
- All monerujo -> مونيروجو
- All Legal stuff in about.xml monerujo ->
مونيروجو (Monerujo)
Ready for merge
Note: there was changes in EN locale to fix some typos. https://github.com/m2049r/xmrwallet/pull/925/commits/90a0654a9c2a7163c4771afd2cbfa8a488d8e766
That's a correction? Is Monerujo an extended name for Moneroj? My understand was that Moneroj was the plural for Monero, as like, the coin.
@lucasmz-dev no idea it's my first time i see "moneroj" i thought it's a typo? Should i drop it?
I'm not sure, to be honest. I'd search more on it...
When I posted the last comment I thought you were the owner of the repo for some reason (?)
On English Wikipedia, I see it being described as that, if you can find any docs from like, getmonero.org saying similar or at least using that word in that context, I'd keep it that way.