Ken Huang comments

Results 75 comments of


                                            Ken Huang

KAFKA-18356 Explicitly setting up instrumentation for inline mocking (Java 21+)

Test in my local This branch: ![CleanShot 2025-04-15 at 21 34 40@2x](https://github.com/user-attachments/assets/7948c2f3-5a0d-46af-8312-9343ba939149) Main: ![CleanShot 2025-04-15 at 21 32 27@2x](https://github.com/user-attachments/assets/7a3ddf71-1a73-457c-b51a-60ce499a35e3)

KAFKA-18600 Cleanup NetworkClient zk related logging

Hello @mumrah, If there are no further changes needed for this PR, perhaps it can be merged. Thanks.

KAFKA-17338 ConsumerConfig should prevent using partition assignors with CONSUMER group protocol

@chia7712, Thanks for your comments, I have addressed all the comments, PTAL

KAFKA-17338 ConsumerConfig should prevent using partition assignors with CONSUMER group protocol

I think that I can address this `check` method in this PR, and remove these config default value when user config the consumer group protocol.

KAFKA-17338 ConsumerConfig should prevent using partition assignors with CONSUMER group protocol

@kirktrue, Thank you for your comments. I have a question regarding [this](https://github.com/apache/kafka/pull/16899#discussion_r1763579857): - Should we treat this as an issue and resolve it? - Or, is it not considered an...

KAFKA-17338 ConsumerConfig should prevent using partition assignors with CONSUMER group protocol

Hello @kirktrue, I think if this PR pass the CI, and won't have comments, we should merge this PR, WDYT?

KAFKA-17338 ConsumerConfig should prevent using partition assignors with CONSUMER group protocol

Thanks for @lianetm review, addressed all comments

KAFKA-17338 ConsumerConfig should prevent using partition assignors with CONSUMER group protocol

Hello @lianetm, I think this fail test is not related with this PR, I will file a Jira to trace this Issue. ``` Expected an exception of type org.apache.kafka.common.errors.UnknownTopicOrPartitionException; got...

KAFKA-17338 ConsumerConfig should prevent using partition assignors with CONSUMER group protocol

> I think this fail test is not related with this PR, I will file a Jira to trace this Issue. Hello @lianetm The main reason I think is `SESSION_TIMEOUT_MS_CONFIG`...

KAFKA-17696 New consumer background operations unaware of metadata errors

Sorry for late to reply you, > but I'm not sure if it would work or if I even like it— Add a new instance variable to store authorization exceptions...