ngx-slider icon indicating copy to clipboard operation
ngx-slider copied to clipboard

Add timeout for changing active status in focus

Open cthrax opened this issue 4 years ago • 0 comments

There was a problem if the focus was called during a change detection, that may be an angular bug related to hostbinding, but this fixes the issue Also update some of the packages and scripts to be able to run them

If you're in the middle of a change detection and you focus, there is an expressionChangedAfterCheck exception. I think this might be related to a possible bug in angular around HostBinding expressions, but I couldn't quite figure out. I know that the HostBinding call was being made over and over on/off/on/off, seemingly part of every change detection, but I could figure out whether that was expected or not. At any rate, I encountered this when opening an ng-bootstrap modal in the onUserchange event and the two setTimeouts fixed that problem. I attempted to use change detection to fix the issue, but as I mentioned, the hostBindings were being changed all the time, so that failed to fix the issue.

cthrax avatar Jun 11 '20 22:06 cthrax