poclbm icon indicating copy to clipboard operation
poclbm copied to clipboard

Don't exit on wrong username/password. Keep trying with the other servers

Open clopez opened this issue 13 years ago • 5 comments

Don't exit on wrong username/password. Keep trying with the other servers.

Issue #25

clopez avatar Jul 07 '11 04:07 clopez

Please merge also 0e557a1

The previous was broken and the former one is cleaner

clopez avatar Jul 07 '11 12:07 clopez

Thank you. Currently I can't decide if it is OK to not fail on bad credentials. If you can communicate with a pool but it rejects your password this perhaps should just be corrected or the server removed from the list?

m0mchil avatar Jul 09 '11 04:07 m0mchil

I dont think failing to shell is good. Many miners may only be checked once a day. It should continue to do something useful. I think report the error and move on to next server is best. I could see someone starting the miner first then adding a new worker to pool. Or modifying credentials on pool before updating miners. Miner should always be doing something useful if possible.

gominoa avatar Jul 09 '11 06:07 gominoa

How about bail out if only one server specified. Otherwise switch to backup. Not sure what to do if both are NotAuth. Maybe add a counter and bail out if all servers fail?

gominoa avatar Jul 09 '11 08:07 gominoa

I also think that failing to shell is always the worst option of all.

Most of miners are not human-checked more than once a day.

And it's a pity that your mine stopped working because of any error.

Actually as a workaround I wrap the execution of poclbm in a bash script that ensures that it will never end

while true; do ./poclbm [....] sleep 60 done

clopez avatar Jul 09 '11 23:07 clopez