Michael Schmoock

Results 59 comments of Michael Schmoock

Hey, the lua module iteself containse the MIT license and the Readme points that out. I do not really maintain the module anymore, it has be forked and further developed...

Hey, Lets always construct testcases for changes including the issue number like this ``` C msg = "#issue25 test - HEXVALUE stripped spaces" define ISSUE_25 { return 0xFF; } assert(...)...

Try to run `make test` and see that there are strict testcases for any syntax and logic issues. If there is a bug, construct a valid testcase that we can...

If its separated and includes testcases, yes absolutely.

Hey, what version of lcpp are you using? https://github.com/m-schmoock/lcpp/blob/master/lcpp.lua#L1952 does not relate to such error. - what lib are you trying to load?

Cool, can you make a PR including the testcase?

... will still fix the tests for backup and feeadjuster plugin

@cdecker we need to synchronize some efforts here with your recent `fix-gci` https://github.com/lightningd/plugins/tree/fix-gci branch

> Yeah, was looking mostly to fix from an infra point of view (test runner script, virtualenvs setup, etc), not so much on fixing individual plugins, though I did try...

@rustyrussell I used the semver, though its kinda overkill, especially since it does not even filter out/ignore the 'v' in front of the version string. Some ppl might complain if...