Matt Richards

Results 189 comments of Matt Richards

Hi @zaneselvans thanks for reporting this, seems to be the same issue as what's causing issues on the CI for main. Looking a bit deeper, this is caused by https://github.com/pandas-dev/pandas/pull/48082...

> Do you remember in which other cases this has come up? The only case I could find was this one: https://github.com/geopandas/geopandas/pull/2296#issuecomment-1024841891 which is actually a bit different, it's about...

> But I am open to discussion and other maintainers may have different views. I'm inclined to agree with Martin, to my mind GeoPandas is not a drop in replacement...

>This seems to fall, perhaps neatly, into some core geospatial functionalities one could expect from geopandas, what do you think? From my perspective, I don't think the convenience of your...

Ah sorry, I think I was aware of this but forgot when I wrote that comment. >Do we want to keep that snippet working? Or are we fine with this...

Hi @shogohida, thanks for wanting to contribute (and also @DamyanBG, I would suggest however we let shogohida have a go at this first - but you are most welcome to...

Hi @shogohida, the current error (see the example in the first comment of this issue) comes from inside `infer_schema` here: https://github.com/geopandas/geopandas/blob/174b38c5e379deb7b771102019af42b9b0de7330/geopandas/io/file.py#L552-L555 But given this issue will affect python the pyogrio...

Hey @shraddhafalane sorry unless I'm missing something this has already been done as #2267. There is however one small follow up, https://github.com/geopandas/geopandas/blob/4d29fcfeb065bdcd7fc69968dd647140772cd5cf/geopandas/_vectorized.py#L720-L724 this `almost_equals` in `_vectorized.py` was missed in that...

Right, don't know how I missed that, sorry @shraddhafalane for the confusion.

> Thanks for looking into all of this. Though, I have to admit I am nos excited about these changes. It brings quite a bit of additional complexity to a...