Matt Richards
Matt Richards
Codecov patch failures are not real, they're due to imports in an `if typing.TYPE_CHECKING` block, and the test failure is the folium one, so going to merge this.
To me this seems like it's probably more confusing than before? The primary column is written as null, the spec says it's required and not null, and reading this file...
> And indeed, it gives a whole bunch of errors, it seems up to pandas 2.0. So we might be able to change this in the future when supporting pandas...
With https://github.com/pandas-dev/pandas/pull/54930 this is no longer needed, and I suppose we can close this. (Though longer term it's perhaps still worth looking at setting the NA value to None for...
Merged this with main again now that we support pandas >=2 only. Seems we may as well just do this for consistency, since the behaviour is that the na_value is...
> I'd say let's go ahead and merge this. Agree, easy to revert if there's some unforseen consequence down the line.
Thanks @lar84 for the report, can confirm this is an issue. This unfortunately doesn't look super straightforward to solve on the geopandas side, particularly in this case with a partial...
Just adding to this after looking at #3119 which is similar, that there are two cases here which need to be looked at. If `gdf` is empty, a different code...
I think we can close this one given that we no longer have this issue in CI, and it seems that this should be automatically handled by pandas in user...
ENH: Using GeoDataFrame constructor fails type-checking when including "geometry" or "crs" arguments
(Disclaimer, I'm not a regular pylance user, so this might not be 100% correct) Having a quick look, this seems a bit tricky to solve within geopandas. Looking at the...