tree-sitter-sql icon indicating copy to clipboard operation
tree-sitter-sql copied to clipboard

About how to help merge PRs

Open pplam opened this issue 2 years ago • 5 comments

Hi @m-novikov , is there something I can do to help merging PRs more efficiently? Please let me know if you have any feedback or suggestions :)

pplam avatar Jun 27 '22 03:06 pplam

This mostly question of my personal time :) I'll plan to review and merge your PRs by the end of this week. As I don't have too much time and don't want to block you I'll probably add comments and merge them regardless creating follow up issues. I also wanted to ask what is your use case for the project, because I plan to introduce some changes while working on #42

m-novikov avatar Jun 28 '22 18:06 m-novikov

I merged a couple some PRs, please rebase existing to the latest main.

m-novikov avatar Jun 28 '22 18:06 m-novikov

Thanks for your time @m-novikov , I will do it tomorrow

pplam avatar Jun 28 '22 19:06 pplam

This mostly question of my personal time :) I'll plan to review and merge your PRs by the end of this week. As I don't have too much time and don't want to block you I'll probably add comments and merge them regardless creating follow up issues. I also wanted to ask what is your use case for the project, because I plan to introduce some changes while working on #42

I already understand your situation, I also work here on weekdays, so my PRs will be quite a lot :)

My use case is to parse real-world SQL files then do some analysis on the parse tree. So I'd like to make contributions to make it support as more PostgreSQL grammar as possible, and produce better parse tree and less parse errors.

And by now, I mainly follow the grammar defined in PostgreSQL's docs.

By the way, the ideas described in #42 are great, I fully support such a plan.

pplam avatar Jun 28 '22 20:06 pplam

Hi @m-novikov

I just rebased #40, #41 and #43 , please help review again at your convenient, thanks!

pplam avatar Jun 29 '22 09:06 pplam